[release/10.0.1xx][HotReload] Allow hot reload refresh script injection for 404 status code #51050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ilonatommy
approved these changes
Sep 29, 2025
ilonatommy
added
the
Area-AspNetCore
This was referenced Sep 29, 2025
|
All the failures are not related. |
|
Same issue as #50999 |
|
Note that this is only the |
lewing
changed the title
lewing
approved these changes
Oct 1, 2025
javiercn
force-pushed
the
backport/pr-51027-to-release/10.0.1xx
branch
from
91af25c to
406a0c7
Compare
javiercn
force-pushed
the
backport/pr-51027-to-release/10.0.1xx
branch
from
406a0c7 to
0644d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable hot reload refresh script injection on 404 responses.
Description
Previously, after a 404 re-execution (e.g. via UseStatusCodePagesWithReExecute), hot reload actions stopped because the refresh script was not injected on the 404 response. Change permits injection for 404, adds a log when injection is skipped, and replaces the single 200-only test with positive/negative injection tests. Further refinement of the filtering logic may come later.
Fixes dotnet/aspnetcore#63831
Customer Impact
Developers hitting a 404 during development lost hot reload thereafter, forcing manual refresh/restarts and slowing inner-loop productivity.
Regression?
Risk
Justification: Narrow conditional change (adds 404), added tests, no behavioral impact outside dev hot reload script injection path.
Verification
Packaging changes reviewed?